-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Skip external memory gtest on osx. #6901
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notes:
|
@hcho3 Okay, all 3 major versions are failing. Since we can't fix the libomp version from homebrew, nor does switching xcode version work. The remaining options are:
|
This reverts commit 67b8e4e.
trivialfis
changed the title
[CI] Try different versions of xcode.
[CI] Skip external memory test on osx.
Apr 29, 2021
trivialfis
changed the title
[CI] Skip external memory test on osx.
[CI] Skip external memory gtest on osx.
Apr 29, 2021
hcho3
approved these changes
Apr 29, 2021
RAMitchell
approved these changes
Apr 29, 2021
trivialfis
added a commit
to trivialfis/xgboost
that referenced
this pull request
May 3, 2021
trivialfis
added a commit
that referenced
this pull request
May 3, 2021
* Relax shotgun test. (#6900) It's non-deterministic algorithm, the test is flaky. * Disable pylint error. (#6911) * [CI] Skip external memory gtest on osx. (#6901) * [CI] Fix custom metric test with empty dataset. (#6917) * Reduce Travis environment setup time. (#6912) * Remove unused r from travis. * Don't update homebrew. * Don't install indirect/unused dependencies like libgit2, wget, openssl. * Move graphviz installation to conda. * Relax shotgun test. (#6918) * Relax test for decision stump in distributed environment. (#6919) * Backport cupy fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On updated libomp@12, the external memory test causes internal error in libomp:
So far non of us can reproduce it on outside of CI environment. This PR tried to switch different xcode versions but all ran into various failures. So to unblock the CI I just disable 1 c++ test.