Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Skip external memory gtest on osx. #6901

Merged
merged 8 commits into from
Apr 30, 2021

Conversation

trivialfis
Copy link
Member

@trivialfis trivialfis commented Apr 23, 2021

On updated libomp@12, the external memory test causes internal error in libomp:

1: OMP: Error #131: Thread identifier invalid.

So far non of us can reproduce it on outside of CI environment. This PR tried to switch different xcode versions but all ran into various failures. So to unblock the CI I just disable 1 c++ test.

@trivialfis
Copy link
Member Author

trivialfis commented Apr 23, 2021

Notes:

  • 12.4 is not compatible with libomp 12.0.0
  • 11.7 crashes.
  • 10.3 same as 12.4.
  • clang 11.1: CMake can't find openmp.

@trivialfis
Copy link
Member Author

trivialfis commented Apr 23, 2021

@hcho3 Okay, all 3 major versions are failing. Since we can't fix the libomp version from homebrew, nor does switching xcode version work. The remaining options are:

  • switch to gcc or open-source clang. With clang cmake couldn't find the openmp package ...
  • switch back to travis and try again.

@trivialfis trivialfis changed the title [CI] Try different versions of xcode. [CI] Skip external memory test on osx. Apr 29, 2021
@trivialfis trivialfis changed the title [CI] Skip external memory test on osx. [CI] Skip external memory gtest on osx. Apr 29, 2021
@trivialfis trivialfis mentioned this pull request Apr 29, 2021
6 tasks
@trivialfis trivialfis merged commit db6285f into dmlc:master Apr 30, 2021
@trivialfis trivialfis deleted the github-action-xcode branch April 30, 2021 00:59
trivialfis added a commit to trivialfis/xgboost that referenced this pull request May 3, 2021
trivialfis added a commit that referenced this pull request May 3, 2021
* Relax shotgun test. (#6900)

It's non-deterministic algorithm, the test is flaky.

* Disable pylint error. (#6911)

* [CI] Skip external memory gtest on osx. (#6901)

* [CI] Fix custom metric test with empty dataset. (#6917)

* Reduce Travis environment setup time. (#6912)

* Remove unused r from travis.
* Don't update homebrew.
* Don't install indirect/unused dependencies like libgit2, wget, openssl.
* Move graphviz installation to conda.

* Relax shotgun test. (#6918)

* Relax test for decision stump in distributed environment. (#6919)

* Backport cupy fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants